IW-681: ./mill dashboard.test output is pristine #798

Merged

mph merged 25 commits from IW-681 into main 2026-10-11 17:45:09 +00:00

Conversation 0 Commits 25 Files changed 24 +1523 -40

claude commented 2026-10-11 07:16:15 +00:00

Member

Copy link

Summary

./mill dashboard.test printed about 280 stray lines. Now it prints only the test report. Expected warnings are captured and asserted, not printed.

Defects fixed

1. CaskServer wrote expected diagnostics to stderr (the --dev WARNING, the two "Forgejo not yet implemented" lines). CaskServer.start now takes a diagnosticsLog sink; tests capture it and assert the exact text. (Phase 1)
2. The pollers wrote their lane reports to stderr. IssuePoller and PullRequestPoller take a log sink; tests capture and assert it. (Phase 2)
3. Undertow, XNIO and JBoss Threads wrote INFO chatter on every server start and stop. The dashboard.test JVM loads a logging.properties that sets these libraries to WARNING; LibraryLogLevelsTest pins it. Warnings and errors still print. (Phase 3)

Testing

• Each phase added a test that failed before its fix, and each phase PR passed the full CI suite.
• Acceptance: the reproduction program in analysis.md counts no stray lines in a ./mill dashboard.test run.

Release notes

See project-management/issues/IW-681/release-notes.md (Czech). No change is visible to dashboard users.

Follow-ups

Filed as #795 (dashboard.itest output, CI check for pristine output), #796 (diagnostics sink cleanup, poller test gaps) and #797 (small dashboard fixes).

Closes #681

🤖 Generated with Claude Code

## Summary `./mill dashboard.test` printed about 280 stray lines. Now it prints only the test report. Expected warnings are captured and asserted, not printed. ## Defects fixed 1. **CaskServer wrote expected diagnostics to stderr** (the `--dev` WARNING, the two "Forgejo not yet implemented" lines). `CaskServer.start` now takes a `diagnosticsLog` sink; tests capture it and assert the exact text. (Phase 1) 2. **The pollers wrote their lane reports to stderr.** `IssuePoller` and `PullRequestPoller` take a log sink; tests capture and assert it. (Phase 2) 3. **Undertow, XNIO and JBoss Threads wrote INFO chatter on every server start and stop.** The `dashboard.test` JVM loads a `logging.properties` that sets these libraries to WARNING; `LibraryLogLevelsTest` pins it. Warnings and errors still print. (Phase 3) ## Testing - Each phase added a test that failed before its fix, and each phase PR passed the full CI suite. - Acceptance: the reproduction program in `analysis.md` counts no stray lines in a `./mill dashboard.test` run. ## Release notes See `project-management/issues/IW-681/release-notes.md` (Czech). No change is visible to dashboard users. ## Follow-ups Filed as #795 (`dashboard.itest` output, CI check for pristine output), #796 (diagnostics sink cleanup, poller test gaps) and #797 (small dashboard fixes). Closes #681 🤖 Generated with [Claude Code](https://claude.com/claude-code)

claude added 25 commits 2026-10-11 07:16:15 +00:00

workflow(dx): Create diagnostic analysis for IW-681 ... 32af02d1b6

./mill dashboard.test output is not pristine

Artifacts:
- analysis.md
- issue.md

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01B8ZD5foFWAE2zV1xYojPMa

chore(IW-681): update review-state to tasks_ready 7099db9d49

workflow(dx): Create task index for IW-681 ... 90a26c53f8

./mill dashboard.test output is not pristine

Artifacts:
- tasks.md
- review-state.json (tasks_ready)

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01B8ZD5foFWAE2zV1xYojPMa

docs(IW-681): correct the analysis where review found errors ... dde0014add

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01B8ZD5foFWAE2zV1xYojPMa

docs(IW-681): intake verdict — needs-human ... e1dcaae07f

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01B8ZD5foFWAE2zV1xYojPMa

Merge remote-tracking branch 'origin/main' into IW-681 4c7db61e67

docs(IW-681): apply the answers from the issue ... 78accbe57a

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018fPBZaKwU97SaaHzVo3ePq

chore(IW-681): move review-state card out of the tree 630718fea1

workflow(dx): Create task index for IW-681 ... dcbf36182f

./mill dashboard.test output is not pristine

Artifacts:
- tasks.md

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018fPBZaKwU97SaaHzVo3ePq

docs(IW-681): intake verdict — agent-ready ... d95166c063

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018fPBZaKwU97SaaHzVo3ePq

Merge remote-tracking branch 'origin/main' into IW-681 257a9d2566

Phase 1: context ready ... 6a4a74a77a

Issue: IW-681
Phase: 1 - CaskServer writes expected diagnostics to stderr, and tests cannot capture them

This commit marks the checkpoint for phase 1 context generation.
The CaskServer sink is named diagnosticsLog, because cask.Main
already declares implicit def log; analysis.md and tasks.md follow.
Use dx-fix IW-681 to return to this point.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

workflow(dx): Generate Phase 1 tasks for IW-681 ... dcb36da4c8

CaskServer writes expected diagnostics to stderr, and tests cannot capture them

Artifacts:
- phase-01-tasks.md

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Phase 1: CaskServer writes expected diagnostics to stderr, and tests cannot capture them (#792) 237dc48e9f

chore(IW-681): mark phase 01 complete in tasks.md 7ca5d6e0ce

Phase 2: context ready ... fea2d19f87

Issue: IW-681
Phase: 2 - The pollers write their lane reports to stderr, and tests cannot capture them

This commit marks the checkpoint for phase 2 context generation.
Use dx-fix IW-681 to return to this point.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

workflow(dx): Generate Phase 2 tasks for IW-681 ... 26408d464c

The pollers write their lane reports to stderr, and tests cannot capture them

Artifacts:
- phase-02-tasks.md

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Phase 2: The pollers write their lane reports to stderr, and tests cannot capture them (#793) db9870d380

chore(IW-681): mark phase 02 complete in tasks.md 4d8f50132a

Phase 3: context ready ... 7b9798d1a2

Issue: IW-681
Phase: 3 - Undertow, XNIO and JBoss Threads INFO chatter on every server start and stop

This commit marks the checkpoint for phase 3 context generation.
Use dx-fix IW-681 to return to this point.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

workflow(dx): Generate Phase 3 tasks for IW-681 ... 1b36e392c2

Undertow, XNIO and JBoss Threads INFO chatter on every server start and stop

Artifacts:
- phase-03-tasks.md

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Phase 3: Undertow, XNIO and JBoss Threads INFO chatter on every server start and stop (#794) a88939662e

chore(IW-681): mark phase 03 complete in tasks.md 1666a3aff7

docs(IW-681): add release notes ... 10539e5e5b

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

chore(IW-681): file follow-ups as #795, #796 and #797 ... 70087cf93d

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

mph merged commit 33e14e5f91 into main 2026-10-11 17:45:09 +00:00

mph referenced this pull request from a commit 2026-10-11 17:45:10 +00:00

Merge pull request 'IW-681: ./mill dashboard.test output is pristine' (#798) from IW-681 into main

claude referenced this pull request 2026-10-16 06:55:30 +00:00

Add iw finish command: merge final PR and remove worktree #249

claude referenced this pull request 2026-10-16 08:26:51 +00:00

Add 'merge' command to complete issue workflow from main repo #174

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

agent-ready

  

bug

Something isn't working

  

contract

Run the tool-contract suite on this PR

  

documentation

Improvements or additions to documentation

  

duplicate

This issue or pull request already exists

  

enhancement

New feature or request

  

good first issue

Good for newcomers

  

help wanted

Extra attention is needed

  

invalid

This doesn't seem right

  

needs-human

  

needs-input

Intake asked the human a question on the issue; waiting for the answer

  

question

Further information is requested

  

wontfix

This will not be worked on

No labels

agent-ready

bug

contract

documentation

duplicate

enhancement

good first issue

help wanted

invalid

needs-human

needs-input

question

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

iterative-works/iw-cli!798

No description provided.