Phase 2: Rework for final PR review 17 #751

Merged

claude merged 101 commits from IW-679-phase-02 into IW-679 2026-10-08 00:43:00 +00:00

Conversation 0 Commits 101 Files changed 132 +11249 -337

claude commented 2026-10-08 00:22:35 +00:00

Member

Copy link

Phase 02 implementation for IW-679.

Files

Browse changed files: https://code.iterative.works/iterative-works/iw-cli/-/blob/IW-679-phase-02/

Phase 02 implementation for IW-679. ### Files Browse changed files: https://code.iterative.works/iterative-works/iw-cli/-/blob/IW-679-phase-02/

claude added 101 commits 2026-10-08 00:22:35 +00:00

workflow(wf): Create analysis for IW-612 ... 13c2996647

PhaseAdvance.maybeUpdateReviewState repeats the PhaseMergedCard shape instead of calling PhaseMergedCard.update

Artifacts:
- analysis.md
- issue.md

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

chore(IW-612): update review-state to tasks_ready 6d3e67f749

workflow(wf): Create task index for IW-612 ... bf743dce3a

PhaseAdvance.maybeUpdateReviewState repeats the PhaseMergedCard shape instead of calling PhaseMergedCard.update

Artifacts:
- tasks.md
- review-state.json (tasks_ready)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

docs(IW-612): intake verdict — agent-ready ... 064a49f142

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

workflow(wf): Create analysis for IW-610 ... 471ab488f4

iw issue can neither report nor print an issue's comments, so a reader cannot know a decision is in one

Artifacts:
- analysis.md
- issue.md

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

chore(IW-610): update review-state to tasks_ready 0770920457

workflow(wf): Create task index for IW-610 ... d38d2b0db5

iw issue can neither report nor print an issue's comments, so a reader cannot know a decision is in one

Artifacts:
- tasks.md
- review-state.json (tasks_ready)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

docs(IW-610): intake verdict — agent-ready ... aaedb23c4e

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

workflow(dx): Create diagnostic analysis for IW-607 ... a1d2992bf4

phase-pr and kanon awaitCi can gate a stale head and use up a CI attempt

Artifacts:
- analysis.md
- issue.md

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

chore(IW-607): update review-state to tasks_ready 26b5467c78

workflow(dx): Create task index for IW-607 ... 113d9e6057

phase-pr and kanon awaitCi can gate a stale head and use up a CI attempt

Artifacts:
- tasks.md
- review-state.json (tasks_ready)

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

docs(IW-607): intake verdict — agent-ready ... 70c9d3d791

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Phase 1: context ready ... 7ca0dbe900

Issue: IW-607
Phase: 1 - A resumed phase-pr judges the head the forge held before its push

This commit marks the checkpoint for phase 1 context generation.
Use dx-fix IW-607 to return to this point.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

chore(IW-607): update review-state to context_ready 2c0430973c

workflow(dx): Generate Phase 1 tasks for IW-607 ... 62f4361579

A resumed phase-pr judges the head the forge held before its push

Artifacts:
- phase-01-tasks.md

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

chore(IW-607): update review-state to tasks_ready d994710e77

Phase 1: A resumed phase-pr judges the head the forge held before its push (#689) d8e9c7ee6a

chore(IW-607): update review-state for phase 01 c70446e297

chore(IW-607): mark phase 01 complete in tasks.md 472ddf579c

chore(IW-607): file follow-ups as #690 and #691 ... c2634c37fb

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

docs(IW-607): add release notes ... b479768366

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

chore(IW-607): update review-state to all_complete 7f7b132f9c

Phase 1: context ready ... 557a9d8fcc

Issue: IW-610
Phase: 1 - Comment model + tracker adapters

This commit marks the checkpoint for phase 1 context generation.
Use wf-implement IW-610 to return to this point.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

chore(IW-610): update review-state to context_ready 22fe2b11d4

workflow(wf): Generate Phase 1 tasks for IW-610 ... a38e624cc8

Comment model + tracker adapters

Artifacts:
- phase-01-tasks.md

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

chore(IW-610): update review-state to tasks_ready 2be4fa57ce

workflow(wf): Create analysis for IW-678 ... 6cde18d779

Claude session links: some sessions and some views are not covered

Artifacts:
- analysis.md
- issue.md

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01B8ZD5foFWAE2zV1xYojPMa

docs(IW-678): correct the analysis where review found errors ... 95ddd0807a

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01B8ZD5foFWAE2zV1xYojPMa

chore(IW-678): update review-state to tasks_ready 97f016af56

workflow(wf): Create task index for IW-678 ... b052395917

Claude session links: some sessions and some views are not covered

Artifacts:
- tasks.md
- review-state.json (tasks_ready)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01B8ZD5foFWAE2zV1xYojPMa

docs(IW-678): intake verdict — agent-ready ... c77aef6111

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01B8ZD5foFWAE2zV1xYojPMa

Phase 1: Comment model + tracker adapters (#694) fcc8a73525

chore(IW-610): update review-state for phase 01 f2ae7ead7c

chore(IW-610): mark phase 01 complete in tasks.md 46d77b873c

Phase 2: context ready ... 2bd2dfb472

Issue: IW-610
Phase: 2 - --comments command + formatter

This commit marks the checkpoint for phase 2 context generation.
Use wf-implement IW-610 to return to this point.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

chore(IW-610): update review-state to context_ready db6bc2a066

workflow(wf): Generate Phase 2 tasks for IW-610 ... bf42dc98ec

--comments command + formatter

Artifacts:
- phase-02-tasks.md

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

chore(IW-610): update review-state to tasks_ready b391385f2a

Phase 2: The --comments command + formatter (#695) 4c36467826

chore(IW-610): update review-state for phase 02 9e8ce79dd1

chore(IW-610): mark phase 02 complete in tasks.md 48a2a54320

Phase 1: context ready ... 7440e87c8d

Issue: IW-612
Phase: 1 - phase-advance writes the shared merged card

This commit marks the checkpoint for phase 1 context generation.
Use wf-implement IW-612 to return to this point.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

chore(IW-612): update review-state to context_ready 45192ff7a7

workflow(wf): Generate Phase 1 tasks for IW-612 ... f010d0c1ec

phase-advance writes the shared merged card

Artifacts:
- phase-01-tasks.md

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

chore(IW-612): update review-state to tasks_ready 53e8ecc79a

Phase 1: phase-advance writes the shared merged card (#696) 0323293934

chore(IW-612): update review-state for phase 01 d091c08998

chore(IW-612): mark phase 01 complete in tasks.md 9181333e59

docs(IW-612): add review packet and release notes ... a5dc419c81

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

chore(IW-612): update review-state to all_complete 909f486186

workflow(wf): Create analysis for IW-670 ... ac3fc75093

test/forgejo-issue.bats has no offline case for issue --json

Artifacts:
- analysis.md
- issue.md

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01B8ZD5foFWAE2zV1xYojPMa

workflow(wf): Add intake review notes to IW-670 analysis ... 1b7ffdd921

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01B8ZD5foFWAE2zV1xYojPMa

chore(IW-670): update review-state to tasks_ready 30e33e2e0b

workflow(wf): Create task index for IW-670 ... 61aba38b6b

test/forgejo-issue.bats has no offline case for issue --json

Artifacts:
- tasks.md
- review-state.json (tasks_ready)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01B8ZD5foFWAE2zV1xYojPMa

fix(IW-610): Make iw issue help text and PURPOSE lines match its output ... b1630126a3

The help claimed iw issue prints a URL; it prints title, status,
assignee and description. PURPOSE lines now name formatComments and
--comments.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LSefu2qCBPDzLjnvk1pMAr

workflow: Triage lessons for IW-610 ... 3adc001f5e

Follow-ups filed: 3 (#699, #700, #701), commented: 2 (#456, #552), struck: 0
Fixed in branch: 2 (iw issue help text, PURPOSE lines — b1630126)
Lessons: 0 approved, 1 rejected, 0 still pending

Rejected:
- Exporting a missing env var does not reach an already-running Mill daemon: machine setup problem, already fixed

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LSefu2qCBPDzLjnvk1pMAr

docs(IW-607): rework for final PR review 16 a3f154cc0f

Merge remote-tracking branch 'origin/main' into IW-670 d840eddd57

Merge remote-tracking branch 'origin/main' into IW-678 fbd6b26106

Merge remote-tracking branch 'origin/main' into IW-612 ... fadfa7beb2

# Conflicts:
#	core/commands/PhaseAdvance.scala

Merge remote-tracking branch 'origin/main' into IW-610 ... 872f85d8bb

# Conflicts:
#	core/adapters/ForgejoClient.scala
#	core/adapters/LinearClient.scala
#	core/commands/Issue.scala
#	core/test/ForgejoClientTest.scala
#	core/test/IssueHarnessTest.scala
#	core/test/fixtures/FakeCommandEnv.scala
#	test/forgejo-issue.bats

Merge remote-tracking branch 'origin/main' into IW-607 ... 86f0e611c4

# Conflicts:
#	core/commands/PhasePr.scala

chore(IW-607): move review-state card out of the tree 0999042a95

Phase 2: context ready ... 2002156f94

Issue: IW-607
Phase: 2 - Rework for final PR review 16

This commit marks the checkpoint for phase 2 context generation.
Use dx-fix IW-607 to return to this point.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

workflow(dx): Generate Phase 2 tasks for IW-607 ... 9ef0ec3b6d

Rework for final PR review 16

Artifacts:
- phase-02-tasks.md

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

test(IW-607): read the judged head from the forge's CI calls, not the card ... c490512408

IW-702 on main stopped every command from writing ci_gated_sha, so the
two stale-head tests that read it fail after the merge. They now assert
the head the gate read CI for.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Phase 2: Rework for final PR review 16 (#726) e90b50585c

chore(IW-607): mark phase 02 complete in tasks.md 7279b59e3c

docs(IW-612): rework for final PR review 15 3b8d0fde02

chore(IW-612): move review-state card out of the tree 211cb70e58

Phase 2: context ready ... d6018e2751

Issue: IW-612
Phase: 2 - Rework for final PR review 15

This commit marks the checkpoint for phase 2 context generation.
Use wf-implement IW-612 to return to this point.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

workflow(wf): Generate Phase 2 tasks for IW-612 ... bb543aaa37

Rework for final PR review 15

Artifacts:
- phase-02-tasks.md

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Phase 2: Rework for final PR review 15 (#727) a29cfe9c4d

chore(IW-612): mark phase 02 complete in tasks.md 9f7318ff85

docs(IW-612): regenerate review packet and release notes after phase 2 ... b7f3d0066e

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

chore(IW-610): move review-state card out of the tree 20e8ede077

docs(IW-610): review packet and release notes ... b020d5fd9f

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

chore(IW-670): move review-state card out of the tree fc10821226

Phase 1: context ready ... 61678c5eb7

Issue: IW-670
Phase: 1 - Offline Forgejo issue --json error cases

This commit marks the checkpoint for phase 1 context generation.
Use wf-implement IW-670 to return to this point.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

workflow(wf): Generate Phase 1 tasks for IW-670 ... fcd43c74ac

Offline Forgejo issue --json error cases

Artifacts:
- phase-01-tasks.md

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Phase 1: Offline Forgejo issue --json error cases (#736) 6b995b4b93

chore(IW-670): mark phase 01 complete in tasks.md b4840a819e

docs(IW-670): add review packet and release notes ... dcb45bf84e

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

chore(IW-678): move review-state card out of the tree d7f70a0a09

Phase 1: context ready ... 5f12a13c85

Issue: IW-678
Phase: 1 - Agent detection + config directories (Domain + Infrastructure readers)

This commit marks the checkpoint for phase 1 context generation.
Use wf-implement IW-678 to return to this point.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

workflow(wf): Generate Phase 1 tasks for IW-678 ... 4a339a99dc

Agent detection + config directories (Domain + Infrastructure readers)

Artifacts:
- phase-01-tasks.md

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Phase 1: Agent detection + config directories (Domain + Infrastructure readers) (#738) 4947745739

chore(IW-678): mark phase 01 complete in tasks.md eaf64257c6

Phase 2: context ready ... e7f8a61289

Issue: IW-678
Phase: 2 - Claude links on the `/` board and agent lane (Presentation + route wiring)

This commit marks the checkpoint for phase 2 context generation.
Use wf-implement IW-678 to return to this point.

The analysis High-Level Approach now agrees with the component spec:
the stretched link holds the key, the foot and the agent line (review note 6).

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

workflow(wf): Generate Phase 2 tasks for IW-678 ... 29e3eafef2

Claude links on the `/` board and agent lane (Presentation + route wiring)

Artifacts:
- phase-02-tasks.md

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Phase 2: Claude links on the / board and agent lane (Presentation + route wiring) (#739) 7c543ff654

chore(IW-678): mark phase 02 complete in tasks.md 71bb2b67e5

chore(IW-678): file follow-ups as #740 and #741 ... fb8e948db5

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

docs(IW-678): review packet and release notes ... cdb70a5aac

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Merge pull request 'IW-607: A resumed phase-pr judges the pushed head, not a stale one' (#692) from IW-607 into main ... df28069261

Reviewed-on: #692

Merge pull request 'IW-612: phase-advance writes the shared merged card' (#697) from IW-612 into main ... 84f29fc9be

Reviewed-on: #697

Merge pull request 'IW-610: iw issue reports and prints an issue's comments' (#728) from IW-610 into main ... 225fd28919

Reviewed-on: #728

Merge pull request 'IW-670: Offline Forgejo issue --json error cases in BATS' (#737) from IW-670 into main ... 24868cd673

Reviewed-on: #737

Merge pull request 'IW-678: Claude session links for versioned binaries, per-agent config dirs, and the / board' (#742) from IW-678 into main ... d9e76182fb

Reviewed-on: #742

Merge origin/main into IW-679-phase-02 ... 4421a10b28

Resolve core/commands/Issue.scala: keep the Subcommand fetch path and
pass the whole IssueFetchOptions to fetchAndPrint, so --comments from
main works through the shared runner.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Rework for final PR review 17 ... 695d9c6fba

- Merge origin/main into the branch
- Resolve Issue.scala: the shared runner's fetch passes IssueFetchOptions to fetchAndPrint, so --comments works
- Issue unit tests and issue BATS files pass; lint passes

claude merged commit 7d862467d4 into IW-679 2026-10-08 00:43:00 +00:00

claude deleted branch IW-679-phase-02 2026-10-08 00:43:00 +00:00

claude referenced this pull request from a commit 2026-10-08 00:43:00 +00:00

Phase 2: Rework for final PR review 17 (#751)

mph referenced this pull request from a commit 2026-10-08 00:46:37 +00:00

Merge origin/main into IW-679 to restore ancestry

claude referenced this pull request 2026-10-08 00:47:20 +00:00

IW-679: Shared subcommand runner for six commands #746

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

agent-ready

  

bug

Something isn't working

  

contract

Run the tool-contract suite on this PR

  

documentation

Improvements or additions to documentation

  

duplicate

This issue or pull request already exists

  

enhancement

New feature or request

  

good first issue

Good for newcomers

  

help wanted

Extra attention is needed

  

invalid

This doesn't seem right

  

needs-human

  

needs-input

Intake asked the human a question on the issue; waiting for the answer

  

question

Further information is requested

  

wontfix

This will not be worked on

No labels

agent-ready

bug

contract

documentation

duplicate

enhancement

good first issue

help wanted

invalid

needs-human

needs-input

question

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

iterative-works/iw-cli!751

No description provided.